Re: [PATCH 4/5] phy: qcom: snps-femto-v2: Move PHY init registers to config tables

From: Konrad Dybcio

Date: Tue Aug 25 2026 - 04:57:19 EST


On 8/24/26 8:37 AM, Varadarajan Narayanan wrote:
> The driver currently programs the common PHY register sequence directly in
> qcom_snps_hsphy_init(), with the fixed register writes split around the
> override parameter handling. This makes it hard to support SoCs that need a
> different sequence or different values.

[...]

> + { USB2_PHY_USB_PHY_REFCLK_CTRL, REFCLK_SEL_DEFAULT, REFCLK_SEL_MASK },

This seems to be a pre-existing bug (swapped mask/val)

Konrad