Re: [PATCH v5 1/2] ata: pata_cswarp: Add Amiga cslab ata support

[Geert Uytterhoeven]

Hi Paolo,

On Tue, 25 Aug 2026 at 09:53, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Mon, 24 Aug 2026 at 17:33, Paolo Pisati <p.pisati@xxxxxxxxx> wrote:
> > Driver for the on-board IDE interface on CS-Lab Warp Expansion Card
> > (NOTE that idemode=native has to be set in Warp Configuration)
> >
> > Assisted-by: Claude_Code:claude-opus-5
> > Signed-off-by: Paolo Pisati <p.pisati@xxxxxxxxx>

> > --- /dev/null
> > +++ b/drivers/ata/pata_cswarp.c

> > +static const struct zorro_device_id pata_cswarp_zorro_tbl[] = {
> > +       { ZORRO_PROD_CSLAB_WARP_1260, 0},

FTR, this doesn't build anymore.
You also should include <linux/device-id/zorro.h>.

> > +       { 0 }
>
> Please use named initializers, and drop unneeded zeroes, like Uwe
> just did in all existing Zorro drivers:
>
>     { .id = ZORRO_PROD_CSLAB_WARP_1260 },
>     { }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds