Re: [EXTERNAL] Re: [PATCH net v4 1/2] octeontx2-pf: Fix aura BPID assignment when CONFIG_DCB is enabled

[Subrat Pandey]

> On Tue, Aug 18, 2026 at 02:41:22PM +0530, Subrat Pandey wrote:
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> > index eecee612b7b2..f39b293cc837 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> > @@ -1029,6 +1029,14 @@ static inline int otx2_tc_flower_rule_cnt(struct otx2_nic *pfvf)
> >       return pfvf->flow_cfg->nr_flows;
> >  }
> >
> > +static inline u8 otx2_get_bpid_idx(struct otx2_nic *pfvf, int qidx)
> > +{
> > +     if (IS_ENABLED(CONFIG_DCB))
> > +             return pfvf->queue_to_pfc_map[qidx];
> > +
> > +     return 0;
> > +}
> > +
> 
> Hi,
> 
> As pointed out by sashiko.dev [1], this will not compile if
> CONFIG_DCB is not defined because the compiler will
> evaluate pfvf->queue_to_pfc_map, and that field doesn't exist
> without CONFIG_DCB set.
> 
Thanks for the feedback.
We will replace "if (IS_ENABLED(CONFIG_DCB))" with "#ifdef CONFIG_DCB" and submit next version.

This will fix the compilation issue with CONFIG_DCB disabled.

> [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__sashiko.dev_-23_patchset_20260818091124.1832237-2D1-2Dsubratp-2540marvell.com&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=wZZ_YCNO5D9RQSXP5bimZWkeOo8bsxUc4KuKiYhSdyM&m=u2Rftq_JL82yWJLQKv_1WEZOrHw6DDfP3Bc9OmHMehTc_5XcvYXJc2TFeQ6pvTjs&s=nXAnju47lUpaVCKMkQ8dr2IZ8L_TjyNG-Uvzl4izd70&e=
> 
> --
> pw-bot: changes-requested