Re: [PATCH 5/6] userfaultfd: decouple fault reason from VMA flags

[David Hildenbrand (Arm)]

>>> @@ -2793,14 +2793,14 @@ static inline bool userfaultfd_must_wait(struct userfaultfd_ctx *ctx,
>>>  	 * If VMA has UFFD WP faults enabled and WP fault, wait for userspace to
>>>  	 * resolve the fault.
>>>  	 */
>>> -	if (!pte_write(ptent) && (reason & VM_UFFD_WP))
>>> +	if (!pte_write(ptent) && (reason & USERFAULT_WP))
>>
>> I wonder if you could actually
>>
>> You do this quite a lot and they read a bit horribly with the && and & on the
>> same sight-line. With the changes to the enum proposed above you could do:
>>
>> 	if (!pte_write(ptent) && test_bit(reason, USERFAULT_WP_BIT))
> 
> I find && and & perfectly readable and adding _BIT defines looks really
> excessive to me.

Yeah, that looks alright to me as well.

-- 
Cheers,

David