Re: [PATCH net] net: stmmac: selftests: Pass the IP proto mask in the TC selftest

[Maxime Chevallier]

Hi,

On 8/25/26 09:51, Paolo Abeni wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.
> Full review at: https://netdev-ai.bots.linux.dev/sashiko/

> Would zero-initializing
> both structs ("= { }", as attr already does in the same function), and
> setting keys.bkey.n_proto = htons(ETH_P_IP) together with
> masks.bmask.n_proto = ETHER_TYPE_FULL_MASK given the injected frames are
> IPv4, make the result independent of the stack contents?

Is surely doesn't hurt to explicitely initialize these fields, will do in
V2.

Maxime