Re: [PATCH v7 16/18] mtd: spinand: negotiate optimal controller operating point before dirmap creation
From: Miquel Raynal
Date: Tue Aug 25 2026 - 08:16:02 EST
>>> + if (!ret && spinand->max_read_op.max_freq) {
>>> + if (iface == ODTR)
>>> + spinand->odtr_op_templates.read_cache = best;
>>> + else
>>> + spinand->ssdr_op_templates.read_cache = best;
>>> + spinand->cont_read_possible = false;
>> Why do you disable continuous reads? I know it is not the same as the
>> read template, but it only differs by a few dummy cycles, so everything
>> should work as expected. I believe without complexifying much the logic
>> we should be able to support it.
>
> Yeah, right! No need to disable continuous read as the only difference
> is the dummy cycle count, my bad!
>
> I've updated the logic to re-pair cont_read_cache with the selected
> read_cache variant based on the protocol shape, while ignoring dummy
> cycles. This keeps continuous read enabled without any unnecessary
> complexity. I'll include this in v8.
Excellent, thanks!
Miquèl