Re: [LTP] [PATCH v1 1/1] swap: Add exfat to filesystems requiring tst_fill_file

[Petr Vorel]

Hi all,

[ Cc kernel folks and LKML ]

> Hi!
> > Reviewed-by: Petr Vorel <pvorel@xxxxxxx>

> > And yeah, we need it in kernel 7.2 on any distro :).

... and on any arch, e.g. x86_64 (not just s390x as Jan previously reported [1])

> > Should we somehow mention relevant kernel commit at least in the commit message?

> > e.g.: Change needed since 03a43677ca91 ("exfat: add swap_activate support") from
> > v7.2-rc1.

> That does not make much sense, if swap_activate was added to kernel,
> pre-filling the fallocated file shouldn't be needed anymore.

Good catch, you're right. I'm also confused, before v7.2 swap worked on exfat,
now even with 82a81a7352bc ("exfat: add iomap buffered I/O support") [2]
and your fix 03a43677ca91 ("exfat: add swap_activate support") [3] is not
working. Obviously the fix was not good enough.

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/akzN_iISxNTztbEw@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82a81a7352bcf5f2756ac33d47ee0582737e9a85
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=03a43677ca91e3997355a13b1da6e47329b025e1