Re: [PATCH] arm64: dts: qcom: shikra: Enable dTPM on EVK boards

[Krzysztof Kozlowski]

On 25/08/2026 12:06, Khalid Faisal Ansari wrote:
> 
> On 8/20/2026 2:52 PM, Konrad Dybcio wrote:
>> On 8/20/26 11:16 AM, Khalid Faisal Ansari wrote:
>>> The Shikra EVK boards (CQM, CQS, IQS) carry an ST33 discrete TPM
>>> connected via SPI5. Enable the SPI controller and add the TPM node
>>> with the ST33HTPM compatible and a 20 MHz max clock.
>>>
>>> Depends-on:https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@xxxxxxxxxxxxxxxx/
>> This is not a valid tag to put in the commit message
>>
>> Why haven't you sent the two clearly interdependent patches together?
> 
> I referenced the SPI5 enabling patch because the TPM node addition 
> depends on that change being present. I had followed a similar approach 
> used in an earlier submission 
> (https://lore.kernel.org/all/0afa55d5-20bf-487b-abe0-4e2126ccf453@xxxxxxxxxxxxxxxx/), 
> where the dependency was mentioned in the commit message.
> 
> Since the two changes originate from different internal ownership areas 
> but are functionally interdependent, we have been handling them as 
> separate submissions while documenting the dependency between them.

You have been already told TWICE and you keep arguing.

> 
>>> Signed-off-by: Khalid Faisal Ansari<khalid.ansari@xxxxxxxxxxxxxxxx>
>>> ---
>>> The Shikra EVK boards (CQM, CQS, IQS) have an ST33 discrete TPM (dTPM)
>>> connected over SPI5. Enable the SPI controller and add the TPM node for
>>> all three board variants.
>>>
>>> This series depends on the SPI5 node addition in shikra-evk.dtsi:
>>>    https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@xxxxxxxxxxxxxxxx/
>>> ---
>>>   arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 10 ++++++++++
>>>   arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 10 ++++++++++
>>>   arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 10 ++++++++++
>> Turn this into a single addition to shikra-evk.dtsi
> 
> I intentionally kept the changes in the individual board DTS files 
> rather than placing them in shikra-evk.dtsi. While the current EVK 
> variants (CQM, CQS, and IQS) all carry the ST33 dTPM, a future board 
> could potentially reuse shikra-evk.dtsi without supporting the TPM 
> hardware. Keeping the node in the board-specific DTS files makes the 
> hardware dependency explicit and avoids enabling TPM on boards where it 
> may not be present.

Do not paste us LLM answers, I find it disrespectful in regard to my time.

Which future board could reuse shikra-evk.dtsi? This the DTSI FOR THIS
EVK. Not some future boards.

Best regards,
Krzysztof