Re: [PATCH] ALSA: hda/conexant: Set mic pin VREF to 0x24 on headset mic plug

[songxiebing]

Hi Takashi,

Thank you very much for your suggestion, but some adjustments are
still needed. Setting 0x24 first will cause headphone type recognition,
which will be executed later. I will provide a second version patch,
thank you.

>Then it's better to move the pin setup to the caller; it makes the
>setup more consistent.  While we're at it, rename the function to be
>more intuitive one.  So the change would be something like below.
>
>
>Takashi
>

>+	} else {
>+		snd_hda_codec_write(codec, 0x19, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24);
>+		cx_process_headset_detect_plug_type(codec);
>+	}