Re: [PATCH v3 18/18] mm/huge_memory: drop the redundant mapping argument of __split_frozen_folio

From: Zi Yan

Date: Tue Aug 25 2026 - 22:06:20 EST


On Thu Aug 20, 2026 at 2:55 PM EDT, Kairui Song via B4 Relay wrote:
> From: Kairui Song <kasong@xxxxxxxxxxx>
>
> The mapping parameter only served as a non-NULL check to detect
> whether page cache entries need updating. The xa_state pointer
> conveys exactly the same information: the anon split helper passes
> NULL and the file split helper passes &xas, which is non-NULL iff
> the folio is in the page cache.
>
> Use the xas pointer instead and drop the parameter, along with its
> kerneldoc entry.
>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxxx>
> ---
> mm/huge_memory.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>

Makes sense.

Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>

--
Best Regards,
Yan, Zi