Re: [PATCH v1 1/3] iio: adc: bcm_iproc_adc: sort headers alphabetically

[Marcelo Schmitt]

Hello Mohammad,

On 08/25, mdshahid03@xxxxxxxxx wrote:
> From: Mohammad Shahid <mdshahid03@xxxxxxxxx>
> 
> Sort the Linux kernel headers alphabetically to improve consistency
> and make the include list easier to maintain.
> 
> Signed-off-by: Mohammad Shahid <mdshahid03@xxxxxxxxx>
> ---
>  drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
> index ab66b97d2f04..e46e3761993a 100644
> --- a/drivers/iio/adc/bcm_iproc_adc.c
> +++ b/drivers/iio/adc/bcm_iproc_adc.c
> @@ -3,14 +3,14 @@
>   * Copyright 2016 Broadcom
>   */
>  
> -#include <linux/module.h>
> -#include <linux/io.h>
>  #include <linux/clk.h>
> -#include <linux/mfd/syscon.h>
> -#include <linux/regmap.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
>  #include <linux/platform_device.h>
> +#include <linux/regmap.h>
>  
>  #include <linux/iio/iio.h>

The sorting looks okay to me. Though, there are some includes missing and a
couple of them that don't seem to be needed (delay.h and io.h). Either in
replacement of this patch or as a follow on extra patch (not sure how maintainers
would like to have it in this case), it would be nice to also update the include
list according to include-what-you-use principles.

If you decide to work on the update to make it iwyu compliant, it may be
helpful to set an IIO tailored mapping file such as the one shared by Jonathan
a while ago.
https://lore.kernel.org/linux-iio/20250629194336.34a03946@jic23-huawei/