Re: [PATCH v1 1/1] smb: client: transport: Fix debug printing in __release_mid()

[Andy Shevchenko]

On Wed, Aug 26, 2026 at 01:34:06AM +0200, Yunseong Kim wrote:
> On Tue, 25 Aug 2026 10:30:43 +0200 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> > -			cifs_info("A: 0x%lx S: 0x%lx R: 0x%lx\n",
> > -				  now - midEntry->when_alloc,
> > -				  now - midEntry->when_sent,
> > -				  now - midEntry->when_received);
> > +			pr_debug("slow rsp: cmd %d mid %llu A: 0x%lx S: 0x%lx R: 0x%lx\n",
> > +				 midEntry->command, midEntry->mid,
> 
> The change looks correct to me.
> 
> One minor suggestion: could the format string be split using adjacent
> string literals to avoid the long source line?
> 
>     pr_debug("slow rsp: cmd %d mid %llu "
>              "A: 0x%lx S: 0x%lx R: 0x%lx\n",
>              ...);

No, the idea is to have long string literals. This was exceptionally done
somewhat 15+ years ago.

See f4c014c0dede ("checkpatch: allow printk strings to exceed 80 characters to
maintain their searchability") as the result of the discussion started here:
https://lore.kernel.org/lkml/20080222132612.GA11717@xxxxxxxxxxxxxxxxx/

> > +				 now - midEntry->when_alloc,
> > +				 now - midEntry->when_sent,
> > +				 now - midEntry->when_received);

-- 
With Best Regards,
Andy Shevchenko