Re: [PATCH] i2c: qcom-cci: fix autosuspend cleanup

[Guangshuo Li]

Hi Krzysztof,

On Thu, 20 Aug 2026 at 22:01, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 12/08/2026 11:44, Guangshuo Li wrote:
> > cci_probe() calls pm_runtime_use_autosuspend(), but the remove path
> > does not call the matching pm_runtime_dont_use_autosuspend() before
> > disabling runtime PM.
> >
> > If the autosuspend delay is set to a negative value while autosuspend
> > is enabled, the runtime PM core increments usage_count to prevent
> > runtime suspend. Without undoing the autosuspend setting during
> > teardown, this reference is not dropped and usage_count remains
> > unbalanced.
> >
> > Use devm_pm_runtime_set_active_enabled() to manage the runtime PM
> > state. Its managed cleanup disables autosuspend and runtime PM and
> > restores the suspended state on probe failure and driver removal.
> > Remove the now redundant manual runtime PM cleanup.
> >
> > This issue was found by manual code inspection.
> >
> > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
>
> You sent vast amount of patches, all separate, making it very difficult
> to track and respond in efficient way. Do not do that.
>
> Group your work per subsystem.
>
> You were asked to clarify and respond to incorrect fixes statement. I do
> not see how you clarified and responded at all.
>
> Best regards,
> Krzysztof

Sorry about that. I should have replied to the earlier review comments
explicitly, and I also should not have sent so many separate patches.

I will group future patches by subsystem and make sure to respond
clearly to review feedback before resending.

Thanks for pointing this out.

Best regards,
Guangshuo