Re: [PATCH v3 1/3] mm: khugepaged: fix swap entry value to folio_pfn()

[David Hildenbrand (Arm)]

On 8/26/26 10:16, David Hildenbrand (Arm) wrote:
> On 8/26/26 10:11, Lorenzo Stoakes (ARM) wrote:
>> On Wed, Aug 26, 2026 at 10:08:58AM +0200, David Hildenbrand (Arm) wrote:
>>>
>>> Elaborate.
>>
>> It's overly long, I read it and am confused as to what is 'problematic' or not,
>> it reads weirdly in English and pfn_xxx is the usual convention for naming of
>> pfn's anyway.
> 
> Excuse me, what? Are you now just making up arguments?
To clarify, we have various users of "xxx_pfn" in the tree and I fail to see how
"this is a problematic pfn" -> "problematic_pfn" is odd and why
"pfn_problematic" would be any clearer.

I do agree with the "problematic" aspect. "failed" might indeed be nicer.

-- 
Cheers,

David