Re: [PATCH v2] ALSA: hda/conexant: Refactor headset plug detection
From: Takashi Iwai
Date: Wed Aug 26 2026 - 04:49:56 EST
On Wed, 26 Aug 2026 03:45:12 +0200,
songxiebing wrote:
>
> From: Bob Song <songxiebing@xxxxxxxxxx>
>
> Rename cx_process_headset_plugin() to cx_process_headset_detect_plug_type()
> to better describe what it does, and merge the duplicated CTIA/OMTP
> branches since both select the same pin-widget control value for the mic
> pin.
>
> Move the AC_VERB_SET_PIN_WIDGET_CONTROL write into the caller
> cx_update_headset_mic_vref() so that the mic pin control is applied
> unconditionally while a mic is present, instead of only for CTIA/OMTP
> headsets.
>
> Signed-off-by: Bob Song <songxiebing@xxxxxxxxxx>
> ---
> changes in v2:
> - Optimize code logic and description
This doesn't apply on the latest code, as there was already a cleanup
to achieve a part of your code changes.
Could you rebase to the latest sound.git for-linus branch and
resubmit?
thanks,
Takashi