Re: [PATCH v3 1/2] usb: gadget: goku_udc: move debug output to debugfs

From: Greg Kroah-Hartman

Date: Wed Aug 26 2026 - 06:29:42 EST


On Wed, Aug 26, 2026 at 05:15:06PM +0800, Cheng Lingfei wrote:
> goku_udc exposes diagnostic state through /proc/driver/udc. The single
> global proc entry collides when more than one controller is probed and
> triggers a proc registration warning.
>
> The data is intended only for debugging and is not a userspace ABI. Move it
> under the USB debugfs root and use the PCI device name for a per-device
> directory. Create the file only after the UDC has been registered.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/2026082616-glue-atlas-0cfd@gregkh
> Assisted-by: Codex:gpt-5.6
> Signed-off-by: Cheng Lingfei <chenglingfei@xxxxxxxxxxx>
> ---
> drivers/usb/gadget/udc/goku_udc.c | 47 +++++++++++++++++++++++++++------------
> drivers/usb/gadget/udc/goku_udc.h | 5 ++++-
> 2 files changed, 37 insertions(+), 15 deletions(-)

Slow down please. There's no rush here at all, and by flooding us with
new revisions it doesn't actually allow anyone to review previous ones,
AND it shows you are just pumping out LLM-generated stuff without all
that much thought.

Please wait a few days at the very least before doing new versions of
patch sets.

As pennance, please go and review some outstanding USB patches on the
mailing list, to reduce our review load :)

thanks,

greg k-h