Re: [PATCH] ntfs: do not mark the volume clean in sync_fs when errors were recorded

[Namjae Jeon]

On Mon, Aug 24, 2026 at 2:08 PM Dennis Tighe <dennis.tighe@xxxxxxxxx> wrote:
>
> ntfs_put_super() and the remount-read-only path both clear the dirty bit
> only when NVolErrors(vol) is false. ntfs_sync_fs() clears it
> unconditionally, so any sync() on a volume that recorded an error marks
> that volume clean. A volume without this set is then seen as not needing
> recovery and it does not run one, so whatever went wrong is never repaired.
>
> This change skips resetting the dirty bit when there are volume errors.
>
> Reproduced on a volume whose $MFTMirr does not match $MFT, which sets the
> error flag while leaving the mount read-write: after a write and a sync,
> the on-disk volume flags read 0x0000 with this driver and 0x0001 with the
> guard in place.
>
> Fixes: 6251f0b0de7d ("ntfs: update super block operations")
> Assisted-by: claude:claude-opus-5
> Signed-off-by: Dennis Tighe <dennis.tighe@xxxxxxxxx>
Applied it to #ntfs-next.
Thanks!