Re: [PATCH] x86/virt/tdx: Warn on !4K level in tdh_mem_page_aug()

[Dave Hansen]

On 8/26/26 00:23, Yan Zhao wrote:
> Do not extend the CLFLUSH coverage to make tdh_mem_page_aug() work with
> huge pages. Not only would this scatter huge page related changes across
> multiple series, but it also makes little sense to have tdh_mem_page_aug()
> alone work for huge pages without implementing its counterparts in the
> unmapping and splitting paths.

For me, it's all about simplicity. It's bad to add *complexity* for
future functionality because it might not ever get used. But in this
case, the (Sean-suggested) change is pretty simple. It's more
complicated to *not* fix the bug and *explain* why it's not being fixed
than to just fix the dang thing.

Also, it's just generally a good idea to carry a length along with a
pointer. <cough>strlen()<cough>