Re: [PATCH v2] s390: Warn if kernel command line contains non-printable EBCDIC characters

From: Heiko Carstens

Date: Wed Aug 26 2026 - 11:38:59 EST


On Wed, Aug 26, 2026 at 05:06:00PM +0200, Ilya Leoshkevich wrote:
> +static inline bool has_nonprintable_char(const char *str)
> +{
> + for (int i = 0; str[i]; i++) {
> + unsigned char c = (unsigned char)str[i];

What is the cast good for? Maybe this could be removed when applying.
Anyway, thanks!

Reviewed-by: Heiko Carstens <hca@xxxxxxxxxxxxx>