Re: [PATCH 3/5] mm/huge_memory: reduce indent level in __folio_freeze_and_split_unmapped()

From: Kiryl Shutsemau

Date: Wed Aug 26 2026 - 12:55:36 EST


On Wed, Aug 26, 2026 at 12:34:47PM -0400, Zi Yan wrote:
> On Wed Aug 26, 2026 at 12:20 PM EDT, Kiryl Shutsemau wrote:
> > From: "Kiryl Shutsemau (Meta)" <kas@xxxxxxxxxx>
> >
> > Trivial cleanup: short-circuit the function if folio_ref_freeze() fails.
> > It save an indent level for the whole function.
> >
> > No functional change intended.
> >
> > Signed-off-by: Kiryl Shutsemau (Meta) <kas@xxxxxxxxxx>
> > ---
> > mm/huge_memory.c | 233 +++++++++++++++++++++++------------------------
> > 1 file changed, 115 insertions(+), 118 deletions(-)
> >
>
> Kairui has a series that cleans up __folio_split()[1]. It seems that your
> patch 3, 4, and 5 overlap with his changes (e.g., your patch 3 is the
> same as his patch 3).

Ah, okay. Ignore 3-5 then.

I will review Kairui's patchset instead.

--
Kiryl Shutsemau / Kirill A. Shutemov