Re: [PATCH] ASoC: amd: acp-config: add quirk for more ASUS FA401EA variants

[Shengyu Qu]

Hi Mark,

I've tested your advice and it works well. It should cover all variants.

V2 already sent:
https://lore.kernel.org/all/20260826172050.15686-1-wiagn@xxxxxxx/

Best regards,
Shengyu

在 2026/8/26 22:24, Mark Brown 写道:
> On Wed, Aug 26, 2026 at 05:42:09PM +0800, Shengyu Qu wrote:
> > Existing quirks doesn't cover all known exising FA401EA devices, so add
> > more quirk items to cover them.
>
> > +	{
> > +		.matches = {
> > +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "FA401EA"),
> > +		},
> > +	},
> >   	{
> >   		.matches = {
> >   			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
> >   			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A14 FA401EA"),
> >   		},
> >   	},
> > +	{
> > +		.matches = {
> > +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401EA"),
> > +		},
> > +	},
>
> Do we need all these entries, DMI matches use substr() so I'd expect the
> first entry to match on all the machines that the other two matches,
> unless I'm misunderstanding somehow?