Re: [PATCH v3 4/5] iommu: Add Broadcom BCM2712 IOMMU driver

[Jason Gunthorpe]

> This IOMMU translates memory access requests for the VC6 display
> pipeline and various multimedia devices in the Broadcom BCM2712 SoC used
> on Raspberry Pi 5.
> 
> The driver uses the generic_pt framework to manage the 2-level page
> tables. It also provides support for the centralized L2 TLB (IOMMUC),
> which is shared across the SoC's IOMMU instances and must be flushed
> when modifying or unmapping page table entries.
> 
> Adapted from Raspberry Pi's downstream bcm2712-iommu driver
> (original author Nick Hollinghurst).
> 
> Signed-off-by: Daniel Drake <dan@xxxxxxxxxxxxxxx>

This seems OK to me.

The sashiko remarks all look wrong except maybe the bit about leaving
stale entries in the IOTLB and leaving the ILEGAL_ADR_OFFSET programed

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

-- 
Jason