Re: [PATCH] gpu: nova-core: fix incorrect naming/framing of GSP-FMC firmware

[Alexandre Courbot]

On Wed Aug 26, 2026 at 5:14 PM JST, Zhi Wang wrote:
> On Tue, 25 Aug 2026 21:40:58 +0200
> "Danilo Krummrich" <dakr@xxxxxxxxxx> wrote:
>
>> On Tue Aug 25, 2026 at 10:31 AM CEST, Alexandre Courbot wrote:
>> > The GSP-FMC firmware code lived in `firmware/fsp.rs` and described
>> > itself as running on the FSP. This is incorrect: GSP-FMC is loaded
>> > by the FSP, but runs on the GSP as the loader and verifier of
>> > GSP-RM. FSP secure-boots on its own before the driver even starts.
>> >
>> > Correct the naming and files used to contain the GSP-FMC code, by:
>> >
>> > - Renaming `firmware/fsp.rs` to `firmware/gsp_fmc.rs` (as GSP-FMC
>> > is not the FSP firmware),
>> > - Changing the prefix of some declarations in that file to `FMC` or
>> >   `GspFmc` (interestingly some were already correct),
>> > - Fixing a mismatch (FMC means "First Mutable Code") in `fsp.rst`.
>> 
>> Good catch,
>> 
>> Reviewed-by: Danilo Krummrich <dakr@xxxxxxxxxx>
>> 
>> >       FSP (hardware root of trust, boots from ROM)
>> > -          -> FMC (Falcon Microcontroller, verified by FSP)
>> > +          -> FMC (First Mutable Code, verified by FSP)
>> 
>> That reminds me that I'd like to have a table in
>> Documentation/gpu/nova/ listing and explaining all abbreviations.
>> 
>
> Thanks for catching this. I got this abbreviation from other patch
> comments.
>
>> In nouveau it's a huge mess and all the abbreviations became rather
>> confusing.
>> 
>
> ...
>
>> We already have something is fsp.rst, but I think it is misleading
>> and needs to be fixed as well.
>> 
>
> I just dig some docs, there are multiple FMCs for different
> controllers, here should be GSP-FMC as well.
>
> Alex, you can include the following diff for fixing the chart.

Actually, since you have your own patch fixing the documentation [1],
let's move everything there - can you fold the documentation
abbreviation fix from this patch into yours, since the chart fix also
seems to be there? I will drop that part from this patch when applying.

No need for attribution tag as this is a one-liner.

[1] https://lore.kernel.org/cover.1787754628.git.zhiw@xxxxxxxxxx