Re: [PATCH net 1/2] net: macb: exclude software FCS from TX byte statistics

[Paolo Abeni]

On 8/25/26 5:04 PM, Nicolai Buchwitz wrote:
> Replying to netdev's sashiko
> https://netdev-ai.bots.linux.dev/sashiko/#/message/20260824134703.766708-2-nb%40tipi-net.de:

It looks like you instead replied to the comments from:

https://sashiko.dev/#/patchset/20260824134703.766708-1-nb%40tipi-net.de

Note that our reference saskiko instance is actually the one you
pointed to above, even if the comments are at as slightly different
URL:

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824134703.766708-1-nb%40tipi-net.de

Also note that pre-existing issue should (usually) not be addressed
in the same patchset (unless really bad/exploitable).

Finally I have some concerns WRT patch 2/2: it should bring a
significant performance regression, and the frames transmitted ATM are
still valid (even if 'downgraded' csum wise). It would probably be good
to provide some priv flag to enable/disable such behavior.

I guess some/most users would prefer send 1 frame out of 64K with csum
validation unexpectedly disabled than hit a huge slowdown.

/P