Re: [PATCH 2/8] media: i2c: Add Yoga Book camera ACPI IDs

[Andy Shevchenko]

On Wed, Aug 26, 2026 at 03:22:50PM +0200, Maurizio Casciano wrote:
> The Lenovo Yoga Book YB1-X91 firmware enumerates the front OV2740 as
> OVTI2740 and the rear OV8858 as INT3477. Neither ID currently matches
> its sensor driver, so both I2C devices remain unbound.
> 
> Add the IDs to the corresponding ACPI match tables. Sensor
> configuration and CSI lane quirks are kept in later patches.

For the record can you provide an DSDT excerpt of this device object (no need
to put into commit message, just reply here)?

...

>  static const struct acpi_device_id ov2740_acpi_ids[] = {
>  	{"INT3474"},
> +	{"OVTI2740"},
>  	{}
>  };

Add a separate patch that converts these to use C99 initialisers and follows
the proper style of the formatting (added spaces, removed unneeded blank line).

static const struct acpi_device_id ov2740_acpi_ids[] = {
	{ .id = "INT3474" },
	{ }
};
MODULE_DEVICE_TABLE(acpi, ov2740_acpi_ids);

...

> +#include <linux/acpi.h>

Why?! We only use a single data structure definition which is defined in a
separate header. If this is what Uwe's rework required, I'm pretty much against.
We should not include the all-in-one acpi.h for the cases when we only use
the ID data structure.

I expect to see here linux/device-id/acpi.h.

>  #include <linux/clk.h>
>  #include <linux/delay.h>
>  #include <linux/device.h>

...

> +static const struct acpi_device_id ov8858_acpi_match[] = {
> +	{ "INT3477" },
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(acpi, ov8858_acpi_match);

See above about the style. Also This patch should be split on per-driver basis.

...

>  static struct i2c_driver ov8858_i2c_driver = {
>  	.driver = {
>  		.name = "ov8858",
>  		.pm = &ov8858_pm_ops,
> +		.acpi_match_table = ACPI_PTR(ov8858_acpi_match),

This is wrong to have here (it will induce compiler warning). And in general —
no ACPI_PTR() in a new code.

>  		.of_match_table = ov8858_of_match,
>  	},
>  	.probe		= ov8858_probe,

-- 
With Best Regards,
Andy Shevchenko