Re: [PATCH v3 1/3] dt-bindings: net: nfc: add st,st21nfcd

From: Krzysztof Kozlowski

Date: Thu Aug 27 2026 - 06:28:27 EST


On Thu, Aug 20, 2026 at 08:56:07PM +0000, Kristian Brox wrote:
> reset-gpios:
> description: Output GPIO pin used for resetting the controller
> @@ -36,6 +37,15 @@ properties:
> Specifies that the uicc swp signal can be physically connected to the
> controller
>
> + clocks:
> + maxItems: 1
> + description:
> + External reference clock connected to SYS_CLK.
> +
> + vdd-io-supply:
> + description:
> + Digital I/O supply (VPS_IO).
> +
> required:
> - compatible
> - interrupts
> @@ -49,6 +59,7 @@ if:
> enum:
> - st,st21nfcb-i2c
> - st,st21nfcc-i2c
> + - st,st21nfcd

This is not true. Please open datasheet - it clearly says SPI interface.

> then:
> properties:
> spi-max-frequency: false
> @@ -81,6 +92,26 @@ examples:
> };
> };
>
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {

Both clocks and vdd-io supply are valid for other devices, so just add
them there and drop the new example.

Best regards,
Krzysztof