Re: [PATCH 2/8] watchdog: da9062: Convert to DEFINE_SIMPLE_DEV_PM_OPS()

From: Guenter Roeck

Date: Thu Aug 27 2026 - 09:58:01 EST


On 8/27/26 00:42, Tzung-Bi Shih wrote:
On Wed, Aug 26, 2026 at 01:08:33PM +0700, Triet Hoang wrote:
diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
...
-static SIMPLE_DEV_PM_OPS(da9062_wdt_pm_ops,
+static DEFINE_SIMPLE_DEV_PM_OPS(da9062_wdt_pm_ops,
da9062_wdt_suspend, da9062_wdt_resume);

To be neat, it'd probably like to align the parameters to '(' or simply
combine them into a single line if it fits within the 100-col limit.

The suggestion applies to all other patches in the series as well.


I agree.

Thanks,
Guenter