Re: [PATCH v3 0/3] watchdog: rzv2h: Convert WDTDCR handling to regmap

[Guenter Roeck]

On 8/14/26 12:14, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Hi All,
>
> This patch series converts the WDTDCR register access from raw
> readl/writel variants over to the regmap framework using
> devm_regmap_init_mmio(). This conversion serves as a preparatory
> refactoring step. It allows the driver to subsequently support
> syscon-based system controllers natively by passing along alternative
> regmap handles without forcing messy architectural branching at runtime.

I do not see the issues reported by Sashiko addressed, nor feedback
explaining to me why the reported issues do not apply and/or are false
positives.

Guenter

> Note,
>   - This change was suggested [0]
>     [0] https://lore.kernel.org/all/c3ef312a-4c26-498c-90c8-118c6dc035a0@xxxxxxxxxxxx/
> - Patches are rebased on top of next-20260813
>
> v2->v3:
> - Patch#1, is split from v2 patch #1 to make thing easier to review.
> - Moved unwinding changes to patch#1.
> - Set use_raw_spinlock to true in regmap config as certain watchdog operations
>    runs in an atomic panic context.
> - Updated commit message to reflect the change for patch#3.
>
> v1->v2:
>   - Dropped patch #1 from v1 series.
>   - Switched to use regmap_set/clear_bits()
>
> v2: https://lore.kernel.org/all/20260715133922.2129340-1-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/
> v1: https://lore.kernel.org/all/20260702160457.1884345-1-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (3):
>    watchdog: rzv2h_wdt: Propagate WDTDCR access errors
>    watchdog: rzv2h: Convert WDTDCR handling to regmap
>    watchdog: rzv2h: Drop WDTRCR_RSTIRQS define
>
>   drivers/watchdog/rzv2h_wdt.c | 80 +++++++++++++++++++++++++-----------
>   1 file changed, 57 insertions(+), 23 deletions(-)