Re: [PATCH 06/10] dt-bindings: ufs: Add compatibles for S32N79 Host Controller platform driver

[Larisa Ileana Grigore]

On 8/26/2026 6:57 PM, Conor Dooley wrote:
> On Wed, Aug 26, 2026 at 09:35:01AM -0500, Frank Li wrote:
> > On Wed, Aug 26, 2026 at 03:40:44PM +0200, Larisa Grigore wrote:
> > > [You don't often get email from larisa.grigore@xxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> > >
> > > Document the device tree binding for the NXP S32N79 DWC-based UFS host
> > > controller which is compliant with JESD-223D "Universal Flash Storage Host
> > > Controller Interface" v3.0.
> > >
> > > The controller requires access to the SCM register block and the core
> > > clock rate when M-PHY initialization is performed. Add the optional
> > > nxp,mphy-boot-mode property to select the M-PHY firmware execution
> > > environment.
> > > Currently, the M-PHY firmware can only run from ROM. If the property is
> > > omitted, M-PHY initialization is assumed to be handled externally.
> > >
> > > Signed-off-by: Larisa Grigore <larisa.grigore@xxxxxxxxxxx>
> > > ---
> > >   .../bindings/ufs/nxp,s32n7-ufshc.yaml         | 99 +++++++++++++++++++
> > >   1 file changed, 99 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/ufs/nxp,s32n7-ufshc.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/ufs/nxp,s32n7-ufshc.yaml b/Documentation/devicetree/bindings/ufs/nxp,s32n7-ufshc.yaml
> > > new file mode 100644
> > > index 000000000000..d9d5669be313
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/ufs/nxp,s32n7-ufshc.yaml
> > > @@ -0,0 +1,99 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/ufs/nxp,s32n7-ufshc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: NXP S32N79 Universal Flash Storage (UFS) Controller
> > > +
> > > +maintainers:
> > > +  - Larisa Grigore <larisa.grigore@xxxxxxxxxxx>
> > > +
> > > +# Select only our matches, not all jedec,ufs
> > > +select:
> > > +  properties:
> > > +    compatible:
> > > +      contains:
> > > +        const: nxp,s32n79-ufshc
> > > +  required:
> > > +    - compatible
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - const: nxp,s32n79-ufshc
> > > +      - const: jedec,ufs-3.0
> >
> > Any place actually use this fallback?
>
> I don't think that this exists anywhere already:
> https://lore.kernel.org/all/?q=%22jedec%2Cufs-3.0%22
> $ git checkout korg-next/master
> Previous HEAD position was 2697ef8943c9 Add linux-next specific files for 20260813
> HEAD is now at f82a5da2f049 Add linux-next specific files for 20260826
> $ rg jedec,ufs-3.0
> $
>
> So not entirely sure what the point of this actually is, if the driver
> doesn't use the fallback.
>
> pw-bot: changes-requested
Thank you! Will address it in v2.

Regard,
Larisa

> Thanks,
> Conor.