Re: [PATCH v2 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling

From: Mark Brown

Date: Thu Aug 27 2026 - 12:28:41 EST


On Thu, Aug 27, 2026 at 02:58:04PM +0700, Bui Duc Phuc wrote:

> To be honest, after looking at the code for other MediaTek SoCs, I found quite
> a few logic issues and inconsistent clock handling. This, along with
> the git log history,
> makes me wonder whether these code paths were ever properly tested on
> real hardware.
> Therefore, I have stopped at mt8186 for now.

There's a lot of code there with shaky error handling; probably the
default case works but things blow up relatively easily on error.

Attachment: signature.asc
Description: PGP signature