Re: [PATCH net v2] bnge: add missing ndo_set_features

[Jakub Kicinski]

On Thu, 27 Aug 2026 21:42:30 +0530 Vikas Gupta wrote:
> +	bnge_close_core(bn);
> +	bn->priv_flags = flags;
> +	bnge_set_ring_params(bd);
> +
> +	rc = bnge_open_core(bn);
> +	if (rc) {
> +		netdev_err(dev, "bnge_open_core err: %d\n", rc);
> +		bn->priv_flags = old_flags;
> +		bnge_set_ring_params(bd);
> +		netif_close(dev);

We have been requiring NIC reconfiguration to be resilient against
OOM conditions for years now. bnxt is even older so it got
grandfathered in, but bnge has to do it right. So we will reject
any patch that tries to close / reopen and hope for the best.

If you want a net fix - you should reflect current operation
of the driver - meaning make GRO-HW either forced on or forced off.
(Forced on by leaving it in the netdev->features but not in
->hw_features). Or reject changes while the device is UP
-- 
pw-bot: cr