Re: [PATCH net-next v2 2/2] net: phy: restore the interrupt after a generic-driver bind cycle

[Andrew Lunn]

> Take it back from the MDIO bus interrupt table on both exits from the
> cycle: the cycle does not touch that table, so whatever the bus
> recorded there still stands. A bus that never filled it has nothing to
> give back and its PHY stays polled.

Bit of an odd phrase.

It might be better to explain that mdiobus_alloc() defaults to filling
bus->irq[] for polling.

> +static void phy_restore_genphy_irq(struct phy_device *phydev)
> +{
> +	if (phydev->irq == PHY_POLL)
> +		phydev->irq = phydev->mdio.bus->irq[phydev->mdio.addr];

Why conditional? Maybe it is buried deep in that wall of text?

    Andrew