Re: [PATCH v2 4/6] rust: workqueue: add creation of workqueues

[Daniel Almeida]

> On 7 Aug 2026, at 19:39, Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
> 
> On Fri Aug 7, 2026 at 6:52 PM CEST, Danilo Krummrich wrote:
>>  * new_power_efficient(): WQ_UNBOUND | WQ_POWER_EFFICIENT, add
>>    .percpu(),
> 
> [...]
> 
>> +    pub fn new_power_efficient() -> Builder<TypePowerEfficient> {
>> +        Builder {
>> +            flags: bindings::wq_flags_WQ_UNBOUND | bindings::wq_flags_WQ_POWER_EFFICIENT,
> 
> I actually meant to add WQ_PERCPU, which should be the default for
> WQ_POWER_EFFICIENT, in order to avoid the warning below.
> 
> But I somehow managed to fix it the wrong way around and made WQ_UNBOUND the
> default.
> 
> So, this should just be bindings::wq_flags_WQ_PERCPU |
> bindings::wq_flags_WQ_POWER_EFFICIENT.
> 

It seems that if you make this change, then
Builder<TypePowerEfficient>::percpu() doesn’t do anything anymore, IIUC?
Perhaps it should be removed then?