Re: [PATCH v5] staging: iio: adc: ad7816: Use modern IIO attribute macros

From: Andy Shevchenko

Date: Thu Aug 27 2026 - 16:15:01 EST


On Fri, Aug 28, 2026 at 01:56:42AM +0600, Md. Mahmudul Hasan Mabud wrote:
> Replace the legacy IIO_DEVICE_ATTR() macros with the modern
> IIO_DEVICE_ATTR_RW() and IIO_DEVICE_ATTR_RO() macros.
>
> This includes renaming driver-specific callback functions to
> standard <name>_show() and <name>_store() formats.

...

> }

>

Also drop this blank line. Same for other cases.

> -static IIO_DEVICE_ATTR(mode, 0644,
> - ad7816_show_mode,
> - ad7816_store_mode,
> - 0);
> +static IIO_DEVICE_ATTR_RW(mode, 0);

With that being done, I'm fine with the patch
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

--
With Best Regards,
Andy Shevchenko