Re: [PATCH net v3] bnxt_en: Bound SW TPA IDs to prevent crashes

From: Joe Damato

Date: Thu Aug 27 2026 - 19:13:13 EST


On Thu, Aug 27, 2026 at 04:07:16PM -0700, Michael Chan wrote:
> On Thu, Aug 27, 2026 at 11:57 AM Joe Damato <joe@xxxxxxx> wrote:
>
> > @@ -3831,6 +3834,7 @@ static int bnxt_alloc_tpa_info(struct bnxt *bp)
> > int i, rc;
> >
> > bp->max_tpa = MAX_TPA;
> > + bp->max_tpa_roundup_size = MAX_TPA;
>
> This is strictly not needed. If we return early below, it means the
> chip does not support TPA at all. We skip allocating the TPA array
> for every ring, so it really makes no difference.
>
> BNXT_SUPPORTS_TPA() will be false if we return early. LRO and HW_GRO
> will not be supported. So I would say it's a false positive from
> Sashiko. Thanks.

I see, OK.

I suppose that means I'll have to resubmit the v2 over again in 24hr?