Re: [PATCH 2/3] i2c: ibm_iic: get the irq early in probe

[Andi Shyti]

Hi Rosen,

On Fri, Aug 21, 2026 at 04:02:15PM -0700, Rosen Penev wrote:
> platform_get_irq() can return -EPROBE_DEFER, unlike
> irq_of_map_and_parse(), which helps reduce work done during probe.

same comment for the commit log goes here.

> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

...

> @@ -686,12 +677,19 @@ static int iic_probe(struct platform_device *ofdev)
>  	struct i2c_adapter *adap;
>  	void __iomem *vaddr;
>  	const u32 *freq;
> +	int irq;
>  	int ret;
>  
>  	vaddr = devm_platform_ioremap_resource(ofdev, 0);
>  	if (IS_ERR(vaddr))
>  		return PTR_ERR(vaddr);
>  
> +	irq = platform_get_irq(ofdev, 0);
> +	if (irq == -EPROBE_DEFER)
> +		return irq;

if iic_force_poll is set true, there is no reason to return if
platform_get_irq() fails with EPROBE_DEFER. Check for
iic_force_poll first.

Andi

> +	if (irq < 0)
> +		dev_warn(&ofdev->dev, "using polling mode\n");
> +