[BUG] ath6kl: WARN in ath6kl_htc_pipe_conn_service() at htc_pipe.c:1314, :1342 and :1347 during USB probe

[Farhad Alemi]

Hello,

As part of the kernel research at ASU's SEFCOM
lab, we hit the crash below. Crash reports can be found here:

  https://github.com/farhad-alemi/public_bug_reports/tree/main/138-ath6kl-bmiss_enhance-outside-wmi_ready-guard/

  WARNING: drivers/net/wireless/ath/ath6kl/htc_pipe.c:1314 at
ath6kl_htc_pipe_conn_service+0xb46/0x12c0
drivers/net/wireless/ath/ath6kl/htc_pipe.c:1314, CPU#1:
kworker/1:5/11133
  Call Trace:
   ath6kl_htc_pipe_conn_service+0xb46/0x12c0
drivers/net/wireless/ath/ath6kl/htc_pipe.c:1314
   ath6kl_htc_conn_service drivers/net/wireless/ath/ath6kl/htc-ops.h:42 [inline]
   ath6kl_connectservice+0x16c/0x6b0 drivers/net/wireless/ath/ath6kl/init.c:291
   ath6kl_init_service_ep+0x21e/0x2a0 drivers/net/wireless/ath/ath6kl/init.c:398
   __ath6kl_init_hw_start+0x8d0/0x1260
drivers/net/wireless/ath/ath6kl/init.c:1753
   ath6kl_init_hw_start+0x16/0x80 drivers/net/wireless/ath/ath6kl/init.c:1832
   ath6kl_core_init+0x7cd/0x10b0 drivers/net/wireless/ath/ath6kl/core.c:191
   ath6kl_usb_probe+0x1b78/0x1e20 drivers/net/wireless/ath/ath6kl/usb.c:1162
   usb_probe_interface+0x657/0xc70 drivers/usb/core/driver.c:396
   really_probe+0x267/0xaf0 drivers/base/dd.c:709

  WARNING: drivers/net/wireless/ath/ath6kl/htc_pipe.c:1342 at
ath6kl_htc_pipe_conn_service+0xbdf/0x12c0
  WARNING: drivers/net/wireless/ath/ath6kl/htc_pipe.c:1347 at
ath6kl_htc_pipe_conn_service+0xc3d/0x12c0

Our reproducer.c is available upon request.

Happy to test a patch if that would help.

Regards,