Re: [PATCH v8 07/12] rust: sizes: implement SizeConstants for Alignment

From: Miguel Ojeda

Date: Fri Aug 28 2026 - 02:27:58 EST


On Fri, Aug 28, 2026 at 7:36 AM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>
> The custom is generally to have `Link:` follow tags like `Suggested-by`
> or `Fixes`, but I guess it is also ok to keep them as general context
> when nothing matches.

Yeah, normally one provides a Link tag after e.g. Suggested-by or
Reported-by, but the Link tag is more general, i.e. it is meant to
provide context in general.

What I suggest is using a reference like [1] from somewhere in the
text to the link, so that it is clear what is the context being added
for:

Link: https://... [1]

But sometimes that doesn't make too much sense, and so it is fine to
have the Link: tag on its own too.

By the way, the commit message also has a "code span" in a new line --
I would suggest indenting it and removing the backticks:

Alignment::new::<8>()

Cheers,
Miguel