RE: [Intel-wired-lan] [PATCH net-next 2/2] igb: read SFP module EEPROM through igb_read_sfp_data_byte

[Rinitha, SX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Pawel Dembicki
> Sent: 18 July 2026 22:26
> To: netdev@xxxxxxxxxxxxxxx
> Cc: Pawel Dembicki <paweldembicki@xxxxxxxxx>; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH net-next 2/2] igb: read SFP module EEPROM through igb_read_sfp_data_byte
>
> igb_get_module_info() and igb_get_module_eeprom() use igb_read_phy_reg_i2c(), which accesses the external PHY register space.
> On designs with an external SGMII PHY this returns PHY register contents instead of the SFP module EEPROM requested by ethtool -m.
>
> Use igb_read_sfp_data_byte() for module EEPROM reads. The legacy ethtool module EEPROM offset space maps directly to the I210 I2CCMD module address space: offsets 0x000-0x0ff address the SFP base EEPROM and offsets 0x100-0x1ff address the diagnostics EEPROM.
> 
> Assisted-by: Codex:GPT-5
> Signed-off-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 40 ++++++--------------
> 1 file changed, 12 insertions(+), 28 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@xxxxxxxxx> (A Contingent worker at Intel)