Re: [PATCH v2] serial: 8250_omap: fix wake irq cleared during suspend

[Tony Lindgren]

On Wed, Aug 26, 2026 at 04:53:07PM +0200, Sebastian Andrzej Siewior wrote:
> On 2026-08-25 17:06:07 [-0500], Kendall Willis wrote:
> > The wake irq was cleared in shutdown(), which runs during the suspend
> > sequence, making it impossible to wake the system via UART.
> > Move wake irq setup to probe() and teardown to remove() so the irq
> > remains armed during suspend when the UART is a wakeup source.
> 
> The omap-serial has the same problem, doesn't it?

Yes likely.

> I would still like to see an ACK from Tony here.

Maybe there was some deferred probe type issue with getting the wakeirq
earlier.

In any case if there was an issue getting the wakeirq it should be handled
nowadays with -EPROBE_DEFER.

Reviewed-by: Tony Lindgren <tony.lindgren@xxxxxxxxxxxxxxx>