Re: [PATCH v2 02/11] media: ov8858: support 19.2 MHz clock and CHT gain setup

[Andy Shevchenko]

On Fri, Aug 28, 2026 at 10:28:39AM +0300, Sakari Ailus wrote:

> On Thu, Aug 27, 2026 at 10:46:48PM +0300, Andy Shevchenko wrote:

...

> > > +#define OV8858_XVCLK_FREQ_19_2MHZ	(192 * HZ_PER_MHZ / 10)
> 
> You can do:
> 
> #define OV8858_XVCLK_FREQ_19_2MHZ	(19.2 * HZ_PER_MHZ)
> 
> i.e. no need for a division, the compiler can handle it.

Yes, but that feels not right (converting float to integer at compile-time).
As I said, I think my suggestion _in this case_ was wrong, let leave them
as they are now defined.

-- 
With Best Regards,
Andy Shevchenko