Re: [PATCH] USB: add Compal EXM-G1x modem support

[Johan Hovold]

On Fri, Aug 28, 2026 at 03:56:44PM +0800, Ian Lin wrote:
> Add the USB device ID for the Compal EXM-G1x modem.
> 
> Bind its QMI WWAN interface 8 and expose its vendor-specific serial
> interfaces with protocols 0x30, 0x40, and 0x60 through the option driver.
> 
> Tested on a Compal EXM-G1x modem.

Do you know which chipset this is based on?

> Signed-off-by: Ian Lin <jisayme@xxxxxxxxx>
> ---
>  drivers/net/usb/qmi_wwan.c  | 1 +
>  drivers/usb/serial/option.c | 3 +++

Please split this in two patches as this will go in through two
different subsystems.

Please also include the output of usb-devices (or lsusb -v) in the
commit message (at least for usb serial).

>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 8178a8758..e17afb22c 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1451,6 +1451,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},    /* Cellient MPL200 (rebranded Qualcomm 05c6:9025) */
>  	{QMI_QUIRK_SET_DTR(0x1546, 0x1312, 4)},	/* u-blox LARA-R6 01B */
>  	{QMI_QUIRK_SET_DTR(0x1546, 0x1342, 4)},	/* u-blox LARA-L6 */
> +	{QMI_QUIRK_SET_DTR(0x04b7, 0x8217, 8)},
>  	{QMI_QUIRK_SET_DTR(0x33f8, 0x0104, 4)}, /* Rolling RW101 RMNET */
>  	{QMI_FIXED_INTF(0x2dee, 0x4d22, 5)},    /* MeiG Smart SRM825L */
>  	{QMI_QUIRK_SET_DTR(0x2dee, 0x4d63, 0)}, /* MeiG SRM813Q w/ Modem(PPP) */
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e4ad14375..56b43bf1f 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2547,6 +2547,9 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0640, 0xff),			/* TCL IK512 ECM */
>  	  .driver_info = NCTRL(3) },
>  	{ USB_DEVICE_INTERFACE_CLASS(0x2949, 0x8700, 0xff) },			/* Neoway N723-EA */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x04b7, 0x8217, 0xff, 0xff, 0x30) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x04b7, 0x8217, 0xff, 0xff, 0x40) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x04b7, 0x8217, 0xff, 0xff, 0x60) },

Try to keep the entries sorted by VID/PID and add a comment with the
product name after the first new entry.

>  	{ } /* Terminating entry */
>  };
>  MODULE_DEVICE_TABLE(usb, option_ids);

Johan