Re: [PATCH v2 0/2] iio: light: vcnl4000: support shared IRQs

[Tsz Shan Chan]

On Sat, Aug 22, 2026 at 03:29:57AM +0100, Jonathan Cameron wrote:
> On Mon, 17 Aug 2026 13:55:40 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> 
> > On Fri, Aug 14, 2026 at 02:30:41PM +1000, Tsz Shan Chan wrote:
> > > This series contains two changes for the vcnl4000 driver.
> > > 
> > > Patch 1 makes .num_channels match .channels for vcnl4200. vcnl4040 and
> > > vcnl4000 channel arrays have the same size, so no functional change.
> > > 
> > > Patch 2 adds shared IRQ support. It changes the trigger type from
> > > falling edge to low level and adds IRQF_SHARED. The IRQ handlers return
> > > IRQ_NONE when the device did not generate the interrupt.  
> > 
> > LGTM,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> > 
> See sashiko
> https://sashiko.dev/#/patchset/20260814-vcnl4000-v2-0-9b771290cc1d%40jacques.com.au
> 
> It might be wrong and there isn't a race condition that ends you
> with that condition of stuck level interrupt.  If so just reply here to explain why.
> 
> The one about even disabling is a common issue - the IIO core has
> not explicit tracking of what events are enabled so it is up to the
> driver to quiesce anything necessary on the path down. I didn't look closely
> at these reports though so they may or may not be correct!
> 
> Thanks,
> 
> Jonathan

Those are valid points. Will fix them and send v3.