Re: [PATCH 2/5] dt-bindings: phy: qcom,usb-snps-femto-v2: Add IPQ9650 compatible

[Krzysztof Kozlowski]

On Mon, Aug 24, 2026 at 12:07:42PM +0530, Varadarajan Narayanan wrote:
> Document the IPQ9650 USB high-speed PHY compatible. The PHY uses the SNPS
> HS 6 nm PHY fallback, so allow it in the binding.
> 
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> index 661759b25064..405bfad2080e 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> @@ -20,6 +20,10 @@ properties:
>                - qcom,sa8775p-usb-hs-phy
>                - qcom,sc8280xp-usb-hs-phy
>            - const: qcom,usb-snps-hs-5nm-phy
> +      - items:
> +          - enum:
> +              - qcom,ipq9650-usb-hs-phy
> +          - const: qcom,usb-snps-hs-6nm-phy

I would prefer if we stop adding more generic nm-process-based
compatibles and use SoC based ones. Both as front and fallbacks, for new
devices. I know it will be inconsistent, but OTOH each of such pattern
encourages people to replicate it in new bindings.

Therefore, add simple enum at the beginning of the oneOf like:

oneOf:
  - enum:
      - qcom,ipq9650-usb-hs-phy
  - items:
       ....
     - const: qcom,usb-snps-hs-5nm-phy

>        - items:
>            - enum:
>                - qcom,qcs8300-usb-hs-phy
> 

Best regards,
Krzysztof