[PATCH v3 0/4] phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur
From: Nabige Aala
Date: Fri Aug 28 2026 - 05:46:59 EST
The existing DP PHY PLL and AUX configuration for the Glymur platform
does not fully follow the Hardware Programming Guide requirements for
DP over Type-C, which results in DP link bring-up failures.
Update the DP PHY programming sequence and PLL-related register
settings to align with the latest HPG recommendations. With this
change, DP link training completes successfully on Glymur-based
platforms.
Fixes: d10736db98d2 ("phy: qualcomm: qmp-combo: Add DP offsets and
settings for Glymur platforms")
Signed-off-by: Ritesh Kumar <ritesh.kumar@xxxxxxxxxxxxxxxx>
Signed-off-by: Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
Signed-off-by: Nabige Aala <nabige.aala@xxxxxxxxxxxxxxxx>
Changes in v2:
- Use the DP-specific v8 COM status register definitions
(DP_QSERDES_V8_COM_C_READY_STATUS and DP_QSERDES_V8_COM_CMN_STATUS)
instead of adding new N3 USB/DP variants.(Konrad)
- Drop the qmp_v8_combo_configure_dp_mode() implementation and
reuse the common qmp_combo_configure_dp_mode() helper, restoring
orientation-specific DP_PHY_MODE programming (0x4c/0x5c) and addressing
review comments regarding DP_PHY_MODE handling.
- Include phy-qcom-qmp-dp-qserdes-com-v8.h for the DP COM register
definitions.
- Update patch author to Ritesh Kumar.(Konrad)
- Link to v1:
https://lore.kernel.org/all/20260419-glymur_dp-v1-1-ad1067a8e8ae@xxxxxxxxxxxxxxxx/
Changes in v3:
- Split the monolithic patch into a logical 4-patch series (Dmitry):
- Patch 1: Add DP COM v8 header and fix register layout
- Patch 2: Update DP PHY common init tables
- Patch 3: Update link rate specific DP PHY tables
- Patch 4: Rework DP PHY runtime configuration
- Improved commit messages with detailed explanations for each change
- Better separation of concerns: header additions, table updates, and
runtime logic changes are now in separate patches for easier review
- Link to v2:
https://lore.kernel.org/all/20260721-glymur-phy-conf-v1-1-7c8909552c5e@xxxxxxxxxxxxxxxx/
---
Ritesh Kumar (4):
phy: qualcomm: qmp-combo: Add DP COM v8 header and fix register layout
phy: qualcomm: qmp-combo: Update DP PHY common init tables
phy: qualcomm: qmp-combo: Update link rate specific DP PHY tables
phy: qualcomm: qmp-combo: Rework DP PHY runtime configuration
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 256 ++++++++++++++++++------------
1 file changed, 156 insertions(+), 100 deletions(-)
---
base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
change-id: 20260824-glymur-phy-v3-b67c4702dfb2
Best regards,
--
Nabige Aala <nabige.aala@xxxxxxxxxxxxxxxx>