Re: [PATCH net v2] net: phy: air_en8811h: restore AN8811HB LED GPIO after MCU restart

From: Andrew Lunn

Date: Fri Aug 28 2026 - 09:10:02 EST


> @@ -1265,10 +1258,19 @@ static int an8811hb_config_init(struct phy_device *phydev)
>
> ret = air_leds_init(phydev, EN8811H_LED_COUNT, AIR_PHY_LED_DUR,
> AIR_LED_MODE_USER_DEFINE);
> - if (ret < 0)
> + if (ret < 0) {
> phydev_err(phydev, "Failed to initialize leds: %d\n", ret);
> + return ret;
> + }
>
> - return ret;
> + /* Restore LED GPIO output enables after MCU initialization. */
> + ret = air_phy_buckpbus_reg_modify(phydev, AN8811HB_GPIO_OUTPUT,
> + AN8811HB_GPIO_OUTPUT_345,
> + AN8811HB_GPIO_OUTPUT_345);
> + if (ret < 0)
> + return ret;
> +
> + return 0;

That can be squashed down to:

return ret;

Andrew

---
pw-bot: cr