Re: [PATCH v2 05/11] media: ov8858: Add INT3477 ACPI ID

[Andy Shevchenko]

On Fri, Aug 28, 2026 at 04:24:38PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 28, 2026 at 2:21 PM Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> > On Thu, Aug 27, 2026 at 08:17:50PM +0200, Maurizio Casciano wrote:

...

> > > +             .acpi_match_table = ov8858_acpi_match,
> >
> > Please use ACPI_PTR() for this one. (Also see
> > <URL:https://lore.kernel.org/linux-media/20260828084328.257703-1-sakari.ailus@xxxxxxxxxxxxxxx/T/#t>;
> > this won't produce a compiler warning then.)
> 
> Why?! What's the point in having this?

For the record, while the first patches are okay there, I definitely NAKed
the last one. It's quite controversial.

-- 
With Best Regards,
Andy Shevchenko