Re: [PATCH v5 05/11] drm: nova: Add an info ioctl

[Alistair Popple]

On 2026-08-28 at 13:35 +1000, Alistair Popple <apopple@xxxxxxxxxx> wrote...

[...]

> +/**
> + * DRM_NOVA_INFO_GPU

Now that we have the possiblity for multiple types of info calls I'm going to
rename this and subsequent similar usage to DRM_NOVA_INFO_GPU. That makes future
definitions more consistent and keeps them distinct from other UAPI structs, i.e
DRM_NOVA_INFO_<type>.

 - Alistair

> + *
> + * Query GPU information. The result is returned in a
> + * &struct drm_nova_gpu_info.
> + */
> +#define DRM_NOVA_INFO_GPU		0x00
> +
> +/**
> + * struct drm_nova_gpu_info - GPU information
> + */
> +struct drm_nova_gpu_info {
> +	/**
> +	 * @architecture: GPU architecture identifier. See
> +	 * &enum drm_nova_architecture for currently known architectures.
> +	 */
> +	__u32 architecture;
> +
> +	/**
> +	 * @implementation: GPU implementation identifier.
> +	 */
> +	__u32 implementation;
> +};
> +
>  #define DRM_NOVA_GETPARAM		0x00
>  #define DRM_NOVA_GEM_CREATE		0x01
>  #define DRM_NOVA_GEM_INFO		0x02
> +#define DRM_NOVA_INFO			0x03
>  
>  /* Note: this is an enum so that it can be resolved by Rust bindgen. */
>  enum {
> @@ -104,6 +151,8 @@ enum {
>  						   struct drm_nova_gem_create),
>  	DRM_IOCTL_NOVA_GEM_INFO		= DRM_IOWR(DRM_COMMAND_BASE + DRM_NOVA_GEM_INFO,
>  						   struct drm_nova_gem_info),
> +	DRM_IOCTL_NOVA_INFO		= DRM_IOWR(DRM_COMMAND_BASE + DRM_NOVA_INFO,
> +						   struct drm_nova_info),
>  };
>  
>  #if defined(__cplusplus)
> -- 
> 2.54.0
>