回覆: [PATCH v2 net-next] net: phy: air_en8811h: select LED GPIO pins based on AN8811HB package variant

[WeiTing Lee (李威霆)]

(Resending in plain text, apologies for the duplicate.)

Hi Andrew,

Yes, I've seen Ziyou's patch, which is now at v3
(https://lore.kernel.org/netdev/20260829033844.1975-1-xuziyougm@xxxxxxxxx/).

My patch is a superset of Ziyou's: it also restores the GPIO output
pins in config_init, but additionally selects the correct set of GPIO
pins based on the AN8811HB package variant (HBCN uses GPIOs 0, 1, 15;
HBN uses GPIOs 3, 4, 5).

I'll wait for Ziyou's v3 to be merged, then rebase and send v3 of this
patch on top of it.

Thanks,
Weiting


________________________________________
寄件者: Andrew Lunn <andrew@xxxxxxx>
已傳送: 星期五, 2026 年 8 月 28 日  下午 09:07
收件者: WeiTing Lee (李威霆) <weiting.lee@xxxxxxxxxx>
副本: netdev@xxxxxxxxxxxxxxx <netdev@xxxxxxxxxxxxxxx>; hkallweit1@xxxxxxxxx <hkallweit1@xxxxxxxxx>; linux@xxxxxxxxxxxxxxx <linux@xxxxxxxxxxxxxxx>; davem@xxxxxxxxxxxxx <davem@xxxxxxxxxxxxx>; kuba@xxxxxxxxxx <kuba@xxxxxxxxxx>; edumazet@xxxxxxxxxx <edumazet@xxxxxxxxxx>; pabeni@xxxxxxxxxx <pabeni@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; bjorn@xxxxxxx <bjorn@xxxxxxx>; ericwouds@xxxxxxxxx <ericwouds@xxxxxxxxx>; frank-w@xxxxxxxxxxxxxxx <frank-w@xxxxxxxxxxxxxxx>; Joseph Lin (林蔚煌) <Joseph.Lin@xxxxxxxxxx>; Wenshin Chung (鍾問星) <wenshin.chung@xxxxxxxxxx>; Lucien Jheng (鄭祥鈞) <lucien.jheng@xxxxxxxxxx>; Albert-AL Lee (李家宏) <albert-al.lee@xxxxxxxxxx>
主旨: Re: [PATCH v2 net-next] net: phy: air_en8811h: select LED GPIO pins based on AN8811HB package variant


On Fri, Aug 28, 2026 at 01:05:36PM +0800, Weiting Lee wrote:

> The AN8811HB comes in two package variants, AN8811HBCN and AN8811HBN,

> which use different GPIO pins to drive LED outputs. AN8811HBCN uses

> GPIOs 0, 1, and 15, while AN8811HBN uses GPIOs 3, 4, and 5. Using a

> fixed GPIO assignment causes incorrect LED behavior on one of the

> variants.

>

> Read the package variant from the read-only silicon identification bits

> in AN8811HB_HWTRAP2 at probe time and store it in priv->is_an8811hbcn.

> Add an8811hb_led_gpio_setup() to configure the correct GPIO output pins

> and select lines based on the detected variant, and call it from

> config_init.



Have yo seen the patch:



Ziyou Xu [PATCH net v2] net: phy: air_en8811h: restore AN8811HB LED GPIO after MCU



There is likely to be a merge conflict with it. We probably should get

that patch merged first.



     Andrew