Re: [PATCH v1 03/11] soc: qcom: crypto_virt: add support for create, prepare and import keys

[Krzysztof Kozlowski]

On 27/08/2026 18:07, Linlin Zhang wrote:
> +static void crypto_virt_remove(struct platform_device *pdev)
> +{
> +	virtblk_set_crypto_ops(NULL);
> +}
> +
> +static const struct of_device_id crypto_virt_of_match[] = {
> +	{ .compatible = "qcom,crypto-virt" },

Undocumented ABI, also not really allowed. We don't take bindings for
drivers.

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, crypto_virt_of_match);
> +
> +static struct platform_driver crypto_virt_driver = {
> +	.probe = crypto_virt_probe,
> +	.remove = crypto_virt_remove,
> +	.driver = {
> +		.name = "crypto_virt",
> +		.of_match_table = crypto_virt_of_match,
> +	},
> +};
> +
> +static int __init crypto_virt_init(void)
> +{
> +	return platform_driver_register(&crypto_virt_driver);
> +}
>  module_init(crypto_virt_init);
>  
>  #if IS_MODULE(CONFIG_QCOM_CRYPTO_VIRT)
>  static void __exit crypto_virt_exit(void)
>  {
> -	virtblk_set_crypto_ops(NULL);
> +	platform_driver_unregister(&crypto_virt_driver);

You just added this line, so previous code was simply wrong?

Please read submitting patches doc - you need to organize your work in
proper commits.

Best regards,
Krzysztof